Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Offer expiration dropdown moving on scroll #10964

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

x

@Jarsen136 Jarsen136 requested a review from a team as a code owner September 10, 2024 12:29
@Jarsen136 Jarsen136 requested review from preschian and vikiival and removed request for a team September 10, 2024 12:29
Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit b03b640
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66e14b709d6c280008caf31c
😎 Deploy Preview https://deploy-preview-10964--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vikiival vikiival requested review from hassnian and removed request for vikiival September 10, 2024 14:26
hassnian
hassnian previously approved these changes Sep 11, 2024
@hassnian hassnian added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Sep 11, 2024
@hassnian hassnian dismissed their stale review September 11, 2024 05:01

small improvment

Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small improvement, avoids unnecessary watchers

libs/ui/src/components/NeoDropdown/NeoDropdown.vue Outdated Show resolved Hide resolved
libs/ui/src/components/NeoDropdown/NeoDropdown.vue Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Sep 11, 2024

@vikiival vikiival added this pull request to the merge queue Sep 11, 2024
Merged via the queue into kodadot:main with commit 76bdc5a Sep 11, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offer expiration dropdown moving on scroll
3 participants