Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure index.html exist on root of the folder #10989

Merged
merged 2 commits into from
Sep 17, 2024
Merged

fix: make sure index.html exist on root of the folder #10989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a9f80a
fix: make sure index.html exist on root of the folder
Jarsen136 Sep 16, 2024
6d86781
Merge branch 'main' into issue-10981
vikiival Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions components/codeChecker/CodeChecker.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,11 @@ const onFileSelected = async (file: File) => {
const { indexFile, sketchFile, entries }
= await extractAssetsFromZip(file)

if (!indexFile) {
errorMessage.value = `Index file not found: Please make sure that “index.html” is in the root directory`
return
}

if (!sketchFile) {
errorMessage.value = `Sketch file not found: ${config.sketchFile}`
return
Expand Down
2 changes: 1 addition & 1 deletion components/codeChecker/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ const categorizeFiles = async (
const adjustedPath = path.replace(commonPrefix, '')
const content = await file.text()

if (path.endsWith('index.html')) {
if (path === 'index.html') {
htmlFiles.push({ path: adjustedPath, content })
}
else if (path.endsWith('.js') && !path.includes(config.p5)) {
Expand Down
Loading