Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Listing popup displayed with listing modal #11000

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix: Listing popup displayed with listing modal #11000

merged 1 commit into from
Sep 19, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Sep 18, 2024 •
edited
Loading

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • listing from the nft grid should not be possible in the drop page
  • removed listing cart mini in the drop page

Needs Design check

Screenshot 📸

  • My fix has changed something on UI;
CleanShot.2024-09-18.at.16.33.52.mp4

@hassnian hassnian requested a review from a team as a code owner September 18, 2024 11:32
@hassnian hassnian requested review from vikiival and Jarsen136 and removed request for a team September 18, 2024 11:32
@netlify Netlify
Copy link

netlify bot commented Sep 18, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 157df86
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66eaba486f1e6c0008e8055d
😎 Deploy Preview https://deploy-preview-11000--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@hassnian hassnian requested review from preschian and removed request for vikiival September 18, 2024 11:36
@hassnian hassnian added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Sep 19, 2024
@vikiival vikiival added this pull request to the merge queue Sep 19, 2024
Merged via the queue into kodadot:main with commit fc2b589 Sep 19, 2024
21 of 22 checks passed
This was referenced Sep 19, 2024
Merged
Merged
Merged
This was referenced Sep 30, 2024
Merged
Merged
This was referenced Oct 7, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

Assignees
No one assigned
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Listing popup displayed with listing modal
4 participants
@hassnian @preschian @Jarsen136 @vikiival