Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 evm profile lowercase address #11031

Merged
merged 7 commits into from
Oct 3, 2024
Merged

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Sep 23, 2024

Screenshot 2024-09-23 at 11-54-46 NFT Artist Profile on KodaDot One Stop Shop for Polkadot NFTs

Note:

  • on nft detail, current_owner link to lowercase user profile, many issues to come!

@roiLeo roiLeo requested a review from a team as a code owner September 23, 2024 09:56
@roiLeo roiLeo requested review from vikiival and hassnian and removed request for a team September 23, 2024 09:56
Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 8eef09c
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66fe6d2915cbdb00087421df
😎 Deploy Preview https://deploy-preview-11031--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vikiival
Copy link
Member

imo contains would take longer than Eq.
I can possibly treat address case sensitive on indexer or possibly we can lowercase address based on active vm for queries

@roiLeo
Copy link
Contributor Author

roiLeo commented Sep 23, 2024

imo contains would take longer than Eq.

sure

I can possibly treat address case sensitive on indexer or possibly we can lowercase address based on active vm for queries

you might need to update all "off-chain" profile to be lowercase

@hassnian
Copy link
Contributor

imo contains would take longer than Eq.

sure

I can possibly treat address case sensitive on indexer or possibly we can lowercase address based on active vm for queries

you might need to update all "off-chain" profile to be lowercase

@vikiival 👀

@Jarsen136
Copy link
Contributor

I can possibly treat address case sensitive on indexer or possibly we can lowercase address based on active vm for queries

you might need to update all "off-chain" profile to be lowercase

It's needed as some issues start to come out.
related to #11049

components/profile/ProfileDetail.vue Outdated Show resolved Hide resolved
@roiLeo roiLeo changed the title 🔧 base profile contains insensitive 🔧 evm profile lowercase address Sep 30, 2024
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~

Copy link

sonarcloud bot commented Oct 3, 2024

@vikiival vikiival added this pull request to the merge queue Oct 3, 2024
Merged via the queue into kodadot:main with commit ba4ff11 Oct 3, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile is not syncing properly with wallet I dont see my BASE NFTs in my profile
4 participants