Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: faster profile creation #11061

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

hassnian
Copy link
Contributor

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

upload profile images in parallel

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2024-09-30 at 15 22 12

@hassnian hassnian requested a review from a team as a code owner September 30, 2024 10:29
@hassnian hassnian requested review from preschian and vikiival and removed request for a team September 30, 2024 10:29
Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 7478fa9
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66fa7d6efdce9900085af395
😎 Deploy Preview https://deploy-preview-11061--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

sonarcloud bot commented Sep 30, 2024

@vikiival
Copy link
Member

vikiival commented Sep 30, 2024

Copilot

This pull request includes an important change to the composables/useUpdateProfile.ts file to optimize the profile image and banner upload process by using Promise.all. This change ensures that both the profile image and banner are uploaded concurrently, improving the overall performance of the profile update function.

Optimization of profile image and banner upload:

  • composables/useUpdateProfile.ts: Modified the profile image and banner upload logic to use Promise.all, allowing both uploads to occur concurrently. This change replaces sequential uploads with concurrent ones, enhancing performance.

@vikiival vikiival added this pull request to the merge queue Sep 30, 2024
Merged via the queue into kodadot:main with commit ad25fdd Sep 30, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants