Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ParaSpell to v6.1.1 #11066

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Update ParaSpell to v6.1.1 #11066

merged 2 commits into from
Oct 3, 2024

Conversation

dudo50
Copy link
Contributor

@dudo50 dudo50 commented Oct 1, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

(please remove design and QA checks below if not needed)

Context

Following PR updates ParaSpell to the latest version. We introduced a breaking change in asset selection for Para->Para transfer scenarios, but Para to Relay and Relay to Para scenarios used by Kodadot are unaffected, and thus, no breaking change was introduced in this PR. The latest version of ParaSpell was tested on Localhost and mainnet, and everything works well.

  • Closes #<issue_number>
  • Requires deployment <worker/stick/speck>

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ahp/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases
  • Tested in localhost on mainnet
  • [ ]

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@dudo50 dudo50 requested a review from a team as a code owner October 1, 2024 09:27
@dudo50 dudo50 requested review from preschian and hassnian and removed request for a team October 1, 2024 09:27
Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 68137aa
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66fcfec46f73b00008ed03f5
😎 Deploy Preview https://deploy-preview-11066--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

socket-security bot commented Oct 1, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@paraspell/sdk@6.1.1 Transitive: filesystem, network +4 1.58 MB dudo50

🚮 Removed packages: npm/@paraspell/sdk@5.10.0, npm/@vitejs/plugin-vue@4.6.2

View full report↗︎

Copy link

sonarcloud bot commented Oct 2, 2024

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@vikiival vikiival added this pull request to the merge queue Oct 3, 2024
Merged via the queue into kodadot:main with commit f980181 Oct 3, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants