Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1902 fix preloader height issue #1907

Merged
merged 1 commit into from
Jan 18, 2022
Merged

#1902 fix preloader height issue #1907

merged 1 commit into from
Jan 18, 2022

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Jan 18, 2022 •
edited
Loading

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

  • PR closes Preloader text seems overflowing #1902
  • added min-height to the fact text, works fine now. However, if the fact is really big like 4-5 lines, the height might increase itself, I have removed the fixed height as the text is dynamic.

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases

Had issue bounty label ?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot

  • My fix has changed something on UI, a screenshot is best to understand changes for others.

@netlify
Copy link

netlify bot commented Jan 18, 2022 •
edited
Loading

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: c25cb01

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61e673c01f2b1000075a8bcd

😎 Browse the preview: https://deploy-preview-1907--koda-nuxt.netlify.app

@yangwao
Copy link
Member

yangwao commented Jan 18, 2022

Perfect, I’ve sent the payout https://kusama.subscan.io/extrinsic/0xed78bdd70624b6cdb8f1ca0ea4d1da9a481a6e6077db16f6d4407e3e78afa6b1

Let’s grab another issue and get rewarded!
https://github.com/kodadot/nft-gallery/issues/

@yangwao yangwao merged commit b73256c into kodadot:main Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preloader text seems overflowing
2 participants
@prachi00 @yangwao