Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚒️ workflow prettier error #1914

Closed
wants to merge 1 commit into from

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jan 18, 2022

PR type

  • Bugfix
  • changed prettier workflow to run on push

@netlify
Copy link

netlify bot commented Jan 18, 2022

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: b6a607b

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61e69eec525f4a00075632e5

😎 Browse the preview: https://deploy-preview-1914--koda-nuxt.netlify.app

@yangwao
Copy link
Member

yangwao commented Jan 18, 2022

Hmm, best would be having opening code suggestions during PR review?
Like linter does through review dog?

@roiLeo
Copy link
Contributor Author

roiLeo commented Jan 18, 2022

Hmm, best would be having opening code suggestions during PR review? Like linter does through review dog?

What do you want to achieve with this prettier workflow?

@yangwao
Copy link
Member

yangwao commented Jan 18, 2022

Hmm, best would be having opening code suggestions during PR review? Like linter does through review dog?

What do you want to achieve with this prettier workflow?

avoid committing non-formatted code, but probably best would be to catch it through git-hooks I guess?
#1861

@roiLeo
Copy link
Contributor Author

roiLeo commented Jan 18, 2022

closing in favor of #1917

@roiLeo roiLeo closed this Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants