Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move mint settings to preferences #1932

Merged
merged 9 commits into from
Jan 22, 2022

Conversation

kkukelka
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Do a quick check before the merge.

Screenshot 2022-01-18 at 19 58 16

Screenshot 2022-01-18 at 20 09 56

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases

Had issue bounty label ?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI, a screenshot is best to understand changes for others.

@netlify
Copy link

netlify bot commented Jan 19, 2022

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 098de7a

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61ea93d62ea3f00008005d32

😎 Browse the preview: https://deploy-preview-1932--koda-nuxt.netlify.app

@yangwao yangwao requested a review from roiLeo January 19, 2022 12:18
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would personally move the translations to the component
check BasicInput

components/shared/Support.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/rmrk/create
options are still here

@vikiival
Copy link
Member

It was just removed from simple mint. @kkukelka pls remove it from NFT tab in /create

@kkukelka
Copy link
Member Author

kkukelka commented Jan 19, 2022

/rmrk/create options are still here

removed now

Screenshot 2022-01-19 at 15 56 58

@yangwao
Copy link
Member

yangwao commented Jan 19, 2022

Can we join this Pr with making the price field KSM expanded?
Pretty please 🥺 🙏

image

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit

@vikiival vikiival requested a review from roiLeo January 19, 2022 19:01
@kkukelka
Copy link
Member Author

Can we join this Pr with making the price field KSM expanded? Pretty please 🥺 🙏

done
Screenshot 2022-01-20 at 07 26 04

@yangwao
Copy link
Member

yangwao commented Jan 22, 2022

@yangwao yangwao merged commit 35f8382 into kodadot:main Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move toggles from Simple Mint to settings
4 participants