Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧼 1678 Collection refactor #1934

Merged
merged 15 commits into from
Jan 20, 2022
Merged

🧼 1678 Collection refactor #1934

merged 15 commits into from
Jan 20, 2022

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Jan 19, 2022 •
edited
Loading

THIS PR DOES NOT FIX 1678 it is more likely just one part

Ref. #1678

  • 🎉 BaseCollectionForm ready
  • 🔝 added Minimark
  • 🧹 refactored CreateCollection using minimark
  • 🎨 removed mb-0 from description input
  • 🧹 removed useless implementation
  • ⚡ added label and protective margin
  • 🧹 optimized imports for /rmrk/create
  • 🐛 account balance were added to the fees
  • ⚡ unique refactored create class
  • ⚡ collection can be now minted without image

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases

Community participation

Screenshot

RMRK:
Screenshot 2022-01-19 at 15 47 08

STATEMINE
Screenshot 2022-01-19 at 15 46 55

@vikiival vikiival requested a review from roiLeo January 19, 2022 14:45
@netlify
Copy link

netlify bot commented Jan 19, 2022 •
edited
Loading

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: d557ece

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61e86804fdb4bf0008ec5796

😎 Browse the preview: https://deploy-preview-1934--koda-nuxt.netlify.app

@github-actions
Copy link
Contributor

You're Pull Request scored a 0.004524886877828055 out of a possible +5 on the sentiment scale. Here's a gif representation of your PR:
Boo from Monsters Inc blinking and looking into space neutrally

@github-actions
Copy link
Contributor

Gif

roiLeo
roiLeo reviewed Jan 19, 2022
View reviewed changes
components/base/BaseCollectionForm.vue Outdated Show resolved Hide resolved
components/base/BaseCollectionForm.vue Outdated Show resolved Hide resolved
components/base/BaseCollectionForm.vue Outdated Show resolved Hide resolved
components/rmrk/Create/CreateCollection.vue Show resolved Hide resolved
@vikiival @roiLeo
Update components/base/BaseCollectionForm.vue
36eb54a 
Co-authored-by: roiLeo <medina.leo42@gmail.com>
@github-actions
Copy link
Contributor

Gif

@vikiival @roiLeo
Update components/base/BaseCollectionForm.vue
711f304 
Co-authored-by: roiLeo <medina.leo42@gmail.com>
@github-actions
Copy link
Contributor

Gif

@github-actions
Copy link
Contributor

Gif

@github-actions
Copy link
Contributor

Gif

@github-actions
Copy link
Contributor

Gif

roiLeo
roiLeo approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yolo, I did not test to create a new collection

@vikiival
Copy link
Member Author

yolo

I've tested it Viki's Collection

@vikiival vikiival merged commit 95c7804 into main Jan 20, 2022
@vikiival vikiival deleted the 1678-collection-refactor branch January 20, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vikiival @roiLeo