Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1944 Hide Identity popover on Auth #1945

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Jan 19, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases

Had issue bounty label ?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI, a screenshot is best to understand changes for others.

@vikiival vikiival self-assigned this Jan 19, 2022
@vikiival vikiival requested a review from yangwao January 19, 2022 18:41
@netlify
Copy link

netlify bot commented Jan 19, 2022

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 1c2c32f

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61e85b4090c80b00076240fe

😎 Browse the preview: https://deploy-preview-1945--koda-nuxt.netlify.app

@github-actions
Copy link
Contributor

Gif

@github-actions
Copy link
Contributor

You're Pull Request scored a 0.004608294930875576 out of a possible +5 on the sentiment scale. Here's a gif representation of your PR:
Boo from Monsters Inc blinking and looking into space neutrally

@yangwao yangwao merged commit 2cd9427 into main Jan 19, 2022
@vikiival vikiival deleted the 1944-hide-popover-on-auth branch January 20, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove hover card at gallery item detail at user address
2 participants