Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing dependencies #2001

Merged
merged 6 commits into from
Jan 21, 2022
Merged

Removing dependencies #2001

merged 6 commits into from
Jan 21, 2022

Conversation

vikiival
Copy link
Member

  • ➖ removed never used dependencies
  • ➖ file-saver as it is not needed anymore
  • ➖ removed freezeframe

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Do a quick check before the merge.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

  • PR closes #<issue_number>
  • <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases

Had issue bounty label ?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI, a screenshot is best to understand changes for others.

@vikiival vikiival self-assigned this Jan 21, 2022
@netlify
Copy link

netlify bot commented Jan 21, 2022 •
edited
Loading

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: cacd48c

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61ea87b7f87e7b0007653222

😎 Browse the preview: https://deploy-preview-2001--koda-nuxt.netlify.app

yangwao
yangwao requested changes Jan 21, 2022
View reviewed changes
Copy link
Member

@yangwao yangwao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥺

package.json Outdated Show resolved Hide resolved
roiLeo
roiLeo reviewed Jan 21, 2022
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what deps.txt is used for?

@yangwao yangwao merged commit dcca282 into main Jan 21, 2022
@vikiival vikiival deleted the k-bye branch January 21, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo left review comments

@yangwao yangwao yangwao requested changes

@kkukelka kkukelka Awaiting requested review from kkukelka

Assignees

@vikiival vikiival

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vikiival @yangwao @roiLeo