Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ spotlight backend sorting #2003

Merged
merged 1 commit into from
Jan 22, 2022
Merged

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jan 21, 2022

We will still need to fix unique column sort

PR type

  • Bugfix

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality
  • Tested

@netlify
Copy link

netlify bot commented Jan 21, 2022

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 89544f7

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61ea8e566050c60008896208

😎 Browse the preview: https://deploy-preview-2003--koda-nuxt.netlify.app

@@ -59,8 +59,9 @@
</b-table-column>

<b-table-column
field="uniqueCollectors"
:label="$t('spotlight.uniqueCollectors')">
field="unique_collectors"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unique_collectors sounds like something we should hack in kodadot/rubick

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit

@yangwao yangwao merged commit 4c5c98e into kodadot:main Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants