-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add related and visited NFTs #2722
Conversation
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@preschian are you showing in the first row the sorted by cheapest ? test cases |
oops, I forgot to mention the order. currently
let me try with that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make the code more reusable 🥺
Also both new components are doing the same logic :) it would be far better to make one common component which can tackle both. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈
oh, it seems not triggering on route change (homepage to item), checking |
updated, ready for review again 🙏🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks definitely cleaner
just move the Min to the constants and make sure that all previous comments are resolved :)
yaps, previous comments should be updated also. some of them outdated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DID NOT test 🧪
code is ~oki
Found container 🫙 is broken on mobile again 😬 and it's moving, but I guess we can postpone it to another following issue. Record_2022-04-02-10-36-02.mp4 |
pay 300 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type
What's new?
Before submitting Pull Request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot