Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vue-social-sharing plugin #286

Merged
merged 8 commits into from
Apr 20, 2021
Merged

Add vue-social-sharing plugin #286

merged 8 commits into from
Apr 20, 2021

Conversation

JKrupinski
Copy link
Contributor

Related to #161

My proposition is to add vue-social-sharing package. I've added ShareNetwork component which helps share link to a facebook.
Twitter, Telegram, Line can be added too. With this plugin you can share content without leaving kodadot page.

More details here: https://github.com/nicolasbeauvais/vue-social-sharing

You can see new facebook icon in the nft detail page
alt text

@yangwao
Copy link
Member

yangwao commented Apr 11, 2021

I was thinking.. what if we could make a show in a default state with just a Twitter button and three dots?
Under three dots could expand into rest buttons?
The purpose of this would be to preserve and keep users low on brain load.
Towards cleaner and highlighting only buttons which are more used for now :)

Dots could be, probably horizontal fit better?
https://fontawesome.com/icons/ellipsis-v?style=solid
https://fontawesome.com/icons/ellipsis-h?style=solid

Or there could be alt, hide them all under https://fontawesome.com/icons/share-alt?style=solid

@yangwao
Copy link
Member

yangwao commented Apr 11, 2021

Oh missed the first part.

Sure, I'm up to adding vue-social-sharing.

@vikiival
Copy link
Member

Yeah, It would be awesome to have a plugin for that

@JKrupinski
Copy link
Contributor Author

Good idea @yangwao I think we can hide them all under share-alt icon

@JKrupinski JKrupinski changed the title Add vue-social-sharing plugin WIP: Add vue-social-sharing plugin Apr 14, 2021
@yangwao
Copy link
Member

yangwao commented Apr 15, 2021

I mean, I would add even embeding button and leave just copy link and share, to cut on ones brain load :)

Pic from Twitter

IMG_20210415_094215

@yangwao yangwao mentioned this pull request Apr 15, 2021
@JKrupinski JKrupinski changed the title WIP: Add vue-social-sharing plugin Add vue-social-sharing plugin Apr 16, 2021
@yangwao yangwao merged commit 1c097c5 into kodadot:main Apr 20, 2021
@JKrupinski JKrupinski deleted the feature/161 branch April 24, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants