Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(2222, 2647): passion feed for gallery and landing page #3023

Merged
merged 17 commits into from
May 27, 2022

Conversation

KngZhi
Copy link
Contributor

@KngZhi KngZhi commented May 15, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Feature

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
Screen.Recording.2022-05-15.at.10.45.30.PM.mov

@KngZhi KngZhi requested a review from a team as a code owner May 15, 2022 13:50
@KngZhi KngZhi requested review from kkukelka and removed request for a team May 15, 2022 13:50
@kodabot
Copy link
Collaborator

kodabot commented May 15, 2022

SUCCESS @KngZhi PR for issue #2222 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented May 15, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 77bc203
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/629085a2765b3300098d0fcc
😎 Deploy Preview https://deploy-preview-3023--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@KngZhi KngZhi changed the title issue 2222 passion gallery feat(2222): passion gallery May 15, 2022
@KngZhi
Copy link
Contributor Author

KngZhi commented May 15, 2022

You can check the effect when Rubick was deployed.

kodadot/rubick#82

@yangwao
Copy link
Member

yangwao commented May 15, 2022

You can check the effect when Rubick was deployed.

let's a link which PR on Rubick?

@KngZhi
Copy link
Contributor Author

KngZhi commented May 15, 2022

You can check the effect when Rubick was deployed.

let's a link which PR on Rubick?

updated

@KngZhi KngZhi changed the title feat(2222): passion gallery feat(2222, 2647): passion feed for gallery and landing page May 16, 2022
@petersopko
Copy link
Contributor

@KngZhi actually, I've found out what the problem is with the linked issue which you've been unassigned from (#2647)
If you want to close multiple issues with one PR you need to use different format, i.e. closes #1, closes #2, otherwise bot doesn't know it's closing issue and not just linked issue 🚀 https://stackoverflow.com/questions/60027222/github-how-can-i-close-the-two-issues-with-commit-message

@KngZhi
Copy link
Contributor Author

KngZhi commented May 17, 2022

@KngZhi actually, I've found out what the problem is with the linked issue which you've been unassigned from (#2647) If you want to close multiple issues with one PR you need to use different format, i.e. closes #1, closes #2, otherwise bot doesn't know it's closing issue and not just linked issue 🚀 https://stackoverflow.com/questions/60027222/github-how-can-i-close-the-two-issues-with-commit-message

@petersopko Oh, I see, learned, didn't realize the closes matters. Many thanks for the info and link!

Copy link
Member

@kkukelka kkukelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, i totally forgot about this PR. would these changes be ok with you?

components/landing/Landing.vue Outdated Show resolved Hide resolved
components/rmrk/Gallery/Gallery.vue Outdated Show resolved Hide resolved
components/rmrk/Gallery/NewestList.vue Outdated Show resolved Hide resolved
components/rmrk/Gallery/LatestSales.vue Outdated Show resolved Hide resolved
@KngZhi
Copy link
Contributor Author

KngZhi commented May 27, 2022

sorry, i totally forgot about this PR. would these changes be ok with you?

No worries :). Those are definitely good changes, thanks for the review, Kilian.

Copy link
Member

@kkukelka kkukelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good now!

@kkukelka kkukelka merged commit e3e9453 into kodadot:main May 27, 2022
@kkukelka
Copy link
Member

pay 350

@yangwao
Copy link
Member

yangwao commented May 27, 2022

😍 Perfect, I’ve sent the payout
💵 $350 @ 67.34 USD/KSM ~ 5.198 $KSM
🧗 DaWoVNNhBTdqJ5iPN3UcaLeamkPpJeGWdrs8LhvX9TQbadc
🔗 0x3d58d29f06f6f569332069bbc94bb798382e4f43df30856c4c4f181d7e7a8e9d

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passion filter on landing page Passion feed filter to gallery view v1.1 - Yulia
5 participants