-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gallery optimization #316
gallery optimization #316
Conversation
@vikiival still not sure about formatBalance decimals, I saw that you changed it to but it doesn't work properly, it shows for example: |
@yangwao please have a test and merge if everything looks good |
Some are paused, some are not. https://deploy-preview-316--nftkodadot.netlify.app/rmrk/gallery Ideas why? Maybe types you are checking for? I'm stoked to have paused gifs back again :D Screen.Recording.2021-05-11.at.10.57.44.movScreen.Recording.2021-05-11.at.10.56.58.mov |
As I wrote in previous comment it will work only for nfts with metadata nft.type (which is mime type). Not sure why some of them don't have it, any ideas? |
Maybe @vikiival can chime on this. I don't know either, I mean eventually we want to migrate to subquery as it offer more room to grow :) |
They were lost in the echo. |
To avoid too many requests I had to change pausing gifs to use nft type property (which is mime type)
It works but looks like this attribute is added only for the newest NFTs
Second thing is that Money component makes too much requests to coingecko on gallery page, I've changed it to use component lazy loading and now it sends requests to coingecko only when NFT is visible
But I have another idea, maybe we can change Money component to get KSM price only once and save it in vuex?
So there will be only one request to coingecko on gallery page