Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subsocial #458

Merged
merged 48 commits into from
Jun 24, 2021
Merged

subsocial #458

merged 48 commits into from
Jun 24, 2021

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Jun 14, 2021 •
edited
Loading

  • WIP: latest subsocial
  • fixed packages
  • Guess What
  • 199 back on track
  • 199 flexing
  • 199 comments WIP
  • 199 WIP reply should work at this moment
  • 199 fails on PostExtension/Comment
  • 199 Upvote works
  • 199 can post <3
  • 199 working post + small css flex
  • 199 in case of fire
  • 199 ready for posting on subsocial
  • 199 in case of fire
  • 199 post should work
  • fixed post resolving

Deliverables:

Comments

  • if post show comments
  • show nested comments

Likes

  • if comment show likes
  • create like
  • change like
  • remove like

Post

  • if !post show post button
  • create post

Edge Cases

  • if !balance show faucet
  • if !account show : "Log in"
  • if !balance disable reply, post and likes
  • reload comments/ikes after change
  • add some magic nftId to IPFS DAG ?

@vikiival vikiival self-assigned this Jun 14, 2021
@vikiival vikiival marked this pull request as draft June 14, 2021 10:47
@vikiival vikiival requested a review from yangwao June 14, 2021 10:47
@yangwao
Copy link
Member

yangwao commented Jun 14, 2021

Merge from Main 👀

@yangwao
Copy link
Member

yangwao commented Jun 19, 2021

Make it pink,
embrace same united style
image

@yangwao
Copy link
Member

yangwao commented Jun 19, 2021

You have to be logged in
-> "You have to be logged in to vote and comment." ?

@yangwao
Copy link
Member

yangwao commented Jun 19, 2021

What about adding some padding lines as Reddit does?
image

@vikiival
199 fixed pr comments
9d3fede
@vikiival
Merge remote-tracking branch 'origin/main' into subsocial
ebea763 
# Conflicts:
#	src/locales/en.json
#	src/styles/global.scss
@github-actions
Copy link
Contributor

Gif

@vikiival vikiival marked this pull request as ready for review June 21, 2021 10:04
@yangwao
Copy link
Member

yangwao commented Jun 22, 2021 •
edited
Loading

Showing there are two comments
image

Probably 2 top-level comments?

But turns out there are 7 of them

I guess we could show a number of top-level comments & total comments?

image

@vikiival
Copy link
Member Author

2 comments have depth 0
other comments are replies to other

@yangwao
Copy link
Member

yangwao commented Jun 22, 2021

I guess we could show a number of top-level comments & total comments?

What about this?

@github-actions
Copy link
Contributor

Gif

@github-actions
Copy link
Contributor

Gif

@github-actions
Copy link
Contributor

Gif

@github-actions
Copy link
Contributor

Gif

@github-actions
Copy link
Contributor

Gif

@yangwao yangwao mentioned this pull request Jun 24, 2021
Closed
5 tasks
@yangwao
Copy link
Member

yangwao commented Jun 24, 2021

lol faucet is gone
image

@github-actions
Copy link
Contributor

Gif

@yangwao yangwao merged commit c2edde4 into main Jun 24, 2021
@yangwao yangwao mentioned this pull request Jun 24, 2021
Merged
@vikiival vikiival deleted the subsocial branch July 13, 2021 09:35
@vikiival vikiival mentioned this pull request Nov 26, 2021
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangwao yangwao Awaiting requested review from yangwao

Assignees

@vikiival vikiival

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vikiival @yangwao