-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(profile): show first nft image as metadata #489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to rename that default file as you mentioned hash bundle there
Still doesn't render... |
I think the card is not showing because we don't provide 'description' and 'title' for twitter and open graph. |
Yes, that would be awesome, yes try that one, to fill title and description from NFT :) Meanwhile, I'm testing it on other PR til lit build with some generic ones #493 |
Oh hint, to mitigate cache, it's fine to add some parameter, like ?abc to end of URL while testing rendering on crawlers, as some cache it hard, even for 3days+ |
This one seems working tho! |
Well now is the question, why doesn't fetch at least the default picture if I don't see any other? |
I mean, let's push it to production. |
For now, I'll merge it as it's at least something and you're welcome to continue cracking why doesn't work:) |
#465 related