Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profile): show first nft image as metadata #489

Merged
merged 9 commits into from
Jun 23, 2021

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jun 22, 2021

#465 related
Capture d’écran 2021-06-22 à 9 02 40 AM

@roiLeo roiLeo changed the title fix(profile): show first nft image as metadata (#465) fix(profile): show first nft image as metadata Jun 22, 2021
@yangwao
Copy link
Member

yangwao commented Jun 22, 2021

Seems doesn't work in tg or Twitter 👀

Any idea what's could going on?
However through some meta plugin I see there is og:image and twitter:image as well

IMG_20210622_091158
IMG_20210622_091217

Copy link
Member

@yangwao yangwao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to rename that default file as you mentioned hash bundle there

src/views/Profile.vue Outdated Show resolved Hide resolved
@yangwao
Copy link
Member

yangwao commented Jun 22, 2021

Still doesn't render...
Maybe try to add these, I sense it's conditional for that
twitter:title
og:title

@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 22, 2021

I think the card is not showing because we don't provide 'description' and 'title' for twitter and open graph.
I will try to set with some data. Should I rely on the first nft ?

@yangwao
Copy link
Member

yangwao commented Jun 22, 2021

Yes, that would be awesome, yes try that one, to fill title and description from NFT :)
The same can go to CollectionItem.vue then :)

Meanwhile, I'm testing it on other PR til lit build with some generic ones #493
Will know in few seconds :)

@yangwao
Copy link
Member

yangwao commented Jun 22, 2021

Oh hint, to mitigate cache, it's fine to add some parameter, like ?abc to end of URL while testing rendering on crawlers, as some cache it hard, even for 3days+

@yangwao
Copy link
Member

yangwao commented Jun 22, 2021

@yangwao
Copy link
Member

yangwao commented Jun 22, 2021

Well now is the question, why doesn't fetch at least the default picture if I don't see any other?
Testing URL https://deploy-preview-489--nftkodadot.netlify.app/rmrk/u/FqCJeGcPidYSsvvmT17fHVaYdE2nXMYgPsBn3CP9gugvZR5?qweqwdsa
image

@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 22, 2021

My SEO plugin show the right picture and description but on twitter card it show the default data and I don't know why.
Capture d’écran 2021-06-22 à 4 34 03 PM
Screenshot 2021-06-22 at 16-36-59 Card Validator Twitter Developers

@yangwao
Copy link
Member

yangwao commented Jun 23, 2021

I mean, let's push it to production.
You are welcome to show on our discord https://discord.gg/35hzy2dXXh
Let's reach me there, @yangwao , so I can process some small bounty for your work :)
You will need to have KSM address

@yangwao
Copy link
Member

yangwao commented Jun 23, 2021

For now, I'll merge it as it's at least something and you're welcome to continue cracking why doesn't work:)

@yangwao yangwao merged commit 476c805 into kodadot:main Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants