Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added watches to view show user properties #516

Merged
merged 3 commits into from
Jun 26, 2021
Merged

Added watches to view show user properties #516

merged 3 commits into from
Jun 26, 2021

Conversation

pandasamanvaya
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.
Let's do a quick check before the merge.
Your contribution will be an eternal part of the community codebase

Before submitting this PR, please make sure:

  • Code builds clean without any erros or warnings
  • Merged recent default branch -- main and I've no conflicts
  • Didn't break any original functionality

Optional

  • You've tested it on mobile and everything works

PR type

  • Bugfix
  • Feature
  • Refactoring

If issue contains bounty label ($,$$,$$$)

  • Your KSM address: <Kusama_address>

Community participation

Screenshot

  • Whenever your fix will change something on UI, a screenshot is more than welcome
    Before
    Screenshot from 2021-06-26 10-20-48

After
Screenshot from 2021-06-26 10-16-23

@pandasamanvaya pandasamanvaya changed the title Added watched to view show user properties Added watches to view show user properties Jun 26, 2021
@yangwao
Copy link
Member

yangwao commented Jun 26, 2021

Probably remove console.logs?
Why icons aren't same size 🤔

@pandasamanvaya
Copy link
Contributor Author

pandasamanvaya commented Jun 26, 2021

Screenshot from 2021-06-26 14-42-57
Now the icons are more or less of the same size. Don't know why the size of fas and fab font-awesome icons are different. Also some of them are not getting rendered like user icon. So, I used users icon instead for displaying the legal name.

@yangwao yangwao merged commit 4902e01 into kodadot:main Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants