New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(media): image theatre preview #519

Merged

yangwao merged 4 commits into kodadot:main from roiLeo:fix/MediaResolver/svg

Jun 28, 2021

Contributor

roiLeo commented Jun 28, 2021

closes #490 & #495

Before submitting this PR, please make sure:

Code builds clean without any erros or warnings
Merged recent default branch -- main and I've no conflicts
Didn't break any original functionality

Optional

I've tested it on mobile and everything works

PR type

Bugfix
Feature
Refactoring

roiLeo added 3 commits

June 28, 2021 10:55


          fix(media): display media svg as Image

0b2ba35


          fix(media): media Image theatre view

878ba82


          fix(media): media Image theatre view

068f42c

Member

yangwao commented Jun 28, 2021

Seems good, but somehow it's not aligned in upper left corner

and bottom right one


          fix(media): media Image theatre view

fd240ae

Member

yangwao commented Jun 28, 2021

okay seems it's working on https://deploy-preview-519--nftkodadot.netlify.app/rmrk/detail/8001754-DE9F84C58887199B5F-WAREYE-WARRIOR_EYE-0000000000000001

yangwao merged commit 89fe83b into kodadot:main

yangwao mentioned this pull request

SQ update 0.22.0 #879

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet