Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preloader as video #569

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Conversation

JKrupinski
Copy link
Contributor

I replaced gif loader with video loader to improve performance

Before submitting this PR, please make sure:

  • Code builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I didn't break any original functionality

Optional

  • I've tested it on mobile and everything works

PR type

  • Feature
  • Refactoring

@yangwao
Copy link
Member

yangwao commented Jul 10, 2021

Is behaving exactly as I described in Discord, it loads just first frame from video :)

Screenrecorder-2021-07-10-15-56-45-851.mp4

@yangwao
Copy link
Member

yangwao commented Jul 12, 2021

on desktop seems now working 👀 I mean WFM but if someone align with my mobile experience we can peak on that later

@yangwao yangwao merged commit 48edd32 into kodadot:main Jul 12, 2021
@JKrupinski JKrupinski deleted the feature/preloader branch July 12, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants