Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price history chart #595

Merged
merged 8 commits into from
Aug 23, 2021
Merged

Price history chart #595

merged 8 commits into from
Aug 23, 2021

Conversation

pandasamanvaya
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.
Let's do a quick check before the merge.
Your contribution will be an eternal part of the community codebase

Before submitting this PR, please make sure:

  • Code builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I didn't break any original functionality

Optional

  • I've tested it on mobile and everything works

PR type

  • Bugfix
  • Feature
  • Refactoring

Screenshot

  • Whenever your fix will change something on UI, a screenshot is more than welcome
    Screenshot from 2021-08-09 20-00-40

@vikiival vikiival self-requested a review August 16, 2021 14:21
@yangwao
Copy link
Member

yangwao commented Aug 17, 2021

Seems the chart on mobile is not perfect.. can we probably hide it?
image

What about putting a chart next to the history table? like in ratio 8 columns for history and 4 cols for the chart?
As data points aren't that dense, doesn't tell me much information per pixel, thus chart just get me the same idea on smaller space :)
image

Tested on https://deploy-preview-595--nftkodadot.netlify.app/rmrk/detail/8789897-6c7794b3f3a8e3dd6f-KSP-105-0000000000000105

Otherwise, it's all good for me and we can merge it afterwards that two points.

@yangwao
Copy link
Member

yangwao commented Aug 22, 2021

Seems works on mobile
image

Price chart is there
image

I guess we are up to fly?

@yangwao
Copy link
Member

yangwao commented Aug 22, 2021

Seems bit cutted now?
image

@yangwao
Copy link
Member

yangwao commented Aug 23, 2021

I mean, we can fix it mobile version later on #618

@yangwao yangwao merged commit 5890d1e into kodadot:main Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants