Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#619 Tell user where is located in app in navbar #642

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

prachi00
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery.
Let's do a quick check before the merge.
Your contribution will be an eternal part of the community codebase

Before submitting this PR, please make sure:

  • Code builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I didn't break any original functionality

Optional

  • I've tested it on mobile and everything works

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new? (maybe part of changelog)

  • closes Tell user where is located in app in navbar #619
    I added a color to the active class in the navbar, so that it gets applied when the route is active even when you reload and hence it persists. router-link-active and navbar-start are buefy class names and I am scoping it within the navbar with the navbar-start class, so that it doesn't affect the router link anywhere else.

If issue contains bounty label ($,$$,$$$)

  • Your KSM address: <Kusama_address>

Community participation

Screenshot

  • Whenever your fix will change something on UI, a screenshot is more than welcome

@prachi00 prachi00 changed the title Tell user where is located in app in navbar #619 Tell user where is located in app in navbar Aug 25, 2021
@yangwao
Copy link
Member

yangwao commented Aug 25, 2021

perfect works after reload for me

image

@yangwao yangwao merged commit 20fefb1 into kodadot:main Aug 25, 2021
@yangwao yangwao mentioned this pull request Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tell user where is located in app in navbar
3 participants