Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions component redesigned #651

Merged
merged 2 commits into from
Aug 29, 2021
Merged

Conversation

prachi00
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery.
Let's do a quick check before the merge.
Your contribution will be an eternal part of the community codebase

Before submitting this PR, please make sure:

  • Code builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I didn't break any original functionality

Optional

  • I've tested it on mobile and everything works

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new? (maybe part of changelog)

  • closes Actions component should be redesigned bit #644 -
    I have focused on how the margins and padding was looking off and fixed that. Other than this, focusing on the UX, I have removed the collapsible dropdown and added the content directly under the actions heading, so in this way one step is reduced for the user. I have also changed the button design and effects have been added on hover.

If issue contains bounty label ($,$$,$$$)

  • Your KSM address: EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU

Community participation

Screenshot

  • Whenever your fix will change something on UI, a screenshot is more than welcome

Screenshot 2021-08-27 at 6 22 24 PM

@vikiival
Copy link
Member

LIST button is dark > user is unable to see it

Screenshot 2021-08-27 at 15 12 33

@prachi00
Copy link
Member Author

LIST button is dark > user is unable to see it

Screenshot 2021-08-27 at 15 12 33

Have changed the colour of the link button, looks better now.

@prachi00 prachi00 closed this Aug 27, 2021
@prachi00 prachi00 reopened this Aug 27, 2021
@yangwao
Copy link
Member

yangwao commented Aug 28, 2021

Looks awesome.
@prachi00 would you like to mind joining it with #611 ?

I guess it's also awesome to merge this PR in current state, if #611 seems hard for you.

@prachi00
Copy link
Member Author

prachi00 commented Aug 28, 2021

I did look at #611, I could not understand it well enough to start implementation. Can we merge this first and then we can have a discussion and I can pick #611 next maybe? @yangwao

@yangwao
Copy link
Member

yangwao commented Aug 29, 2021

Let's merge it :)
Payment sent.

@yangwao yangwao merged commit c31e617 into kodadot:main Aug 29, 2021
@daiagi daiagi mentioned this pull request Oct 14, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Actions component should be redesigned bit
3 participants