Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): locales rework #656

Merged
merged 41 commits into from
Aug 31, 2021
Merged

feat(i18n): locales rework #656

merged 41 commits into from
Aug 31, 2021

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Aug 29, 2021

In Draft should be reviewed.
This issue was a bit painful but now I'm a copy/paste master and fluent in all languages.
Let me know if we should keep .py script.

Before submitting this PR, please make sure:

  • Code builds clean without any errors or warnings (need help with last require and README warn)
  • I've merged recent default branch -- main and I've no conflicts
  • I didn't break any original functionality

Optional

  • I've tested it on mobile and everything works

PR type

  • Feature

What's new? (maybe part of changelog)

Reworked locales

  • bn.json
  • cn.json
  • cz.json
  • de.json
  • en.json
  • es.json
  • fr.json
  • hi.json
  • it.json
  • jp.json
  • ko.json
  • nl.json
  • pl.json
  • pt.json
  • ru.json
  • sk.json
  • tu.json
  • ua.json
  • ur.json
  • vt.json

@yangwao
Copy link
Member

yangwao commented Aug 30, 2021

This issue was a bit painful but now I'm a copy/paste master and fluent in all languages.

vous pourrez désormais parler plusieurs langues 😄

Let me know if we should keep .py script.

For past archival, if it would be needed for something, we can keep it or at some point it will still last in GIT history after deletion, if so we can remove it :)

Okay I've checked for Slovak it's working https://deploy-preview-656--nftkodadot.netlify.app/rmrk/faq
Maybe remove tags and leverage markdown bold using ** ** ?

For me all good, it's looking amazing and we can finally unfreeze translations!
Let me pass this to stewards to check their languages if anything critical is there and we can still fix it in a new way others making PR to their language translations.

@vikiival
Copy link
Member

Let me know if we should keep .py script.

Yes please ❤️

@yangwao
Copy link
Member

yangwao commented Aug 30, 2021

Oh, one last question @roiLeo

What about adding that foldable effect? So whenever one searching for a question, one don't need to see all answers
It's the last point from #101

@vikiival
Copy link
Member

Oh, one last question @roiLeo

What about adding that foldable effect? So whenever one searching for a question, one don't need to see all answers
It's the last point from #101

Let's make it a separated good first issue :)

@roiLeo
Copy link
Contributor Author

roiLeo commented Aug 30, 2021

@yangwao I didn't know if it was still relevant but I can propose something.

I still got one issue (Warning) that I can't fix "Detected usage of the any type" on i18n.ts file.

@yangwao
Copy link
Member

yangwao commented Aug 30, 2021

@yangwao I didn't know if it was still relevant but I can propose something.

Yeah, I mean, rather wait and accept it once it's working, it will be huge upgrade for FAQs :)

I still got one issue (Warning) that I can't fix "Detected usage of the any type" on i18n.ts file.

That sounds like typescript warning 🤔

@roiLeo
Copy link
Contributor Author

roiLeo commented Aug 30, 2021

I made some changes to include collapsible in faq.
By default all opened.
UI looks weird... Should I remove arrow ? or maybe change title width ?

Screenshot

Screenshot 2021-08-30 at 15-00-27 KodaDot - Kusama NFT Market Explorer Low Carbon NFTs

@yangwao
Copy link
Member

yangwao commented Aug 30, 2021

I mean looks good, I would

  • put chevron to the left (to not be random placed)
  • different colour for chevron, maybe try $main? To know it's actionable.
  • maybe smaller text for the headline
  • maybe make it addressable so Question could be linked by # ? i.e. faq#HOW-I-CAN-CREATE-OWN-SHOP? would move your viewport to that unfolded question

All good for me!

image

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work.

maybe rename src/components/rmrk/Faq-rework.vue into FAQ or so ?

Awesome work.Awesome work.

src/components/rmrk/Faq-rework.vue Outdated Show resolved Hide resolved
@roiLeo roiLeo changed the title Draft: feat(i18n): locales rework feat(i18n): locales rework Aug 31, 2021
@roiLeo
Copy link
Contributor Author

roiLeo commented Aug 31, 2021

Screenshot

Screenshot 2021-08-31 at 09-04-04 KodaDot - Kusama NFT Market Explorer Low Carbon NFTs

I still have a small problem with scrolling to the anchor. (For example when you click on chevron)
Same with link like /rmrk/faq#What-wallet-do-I-need-to-mint,-buy-and-collect? doesn't work when I don't have the right locale.

@yangwao
Copy link
Member

yangwao commented Aug 31, 2021

I mean, we can flex addressable later stage...
right now to just dispatch it to live I see this one issue there that you lose headline text as it seems viewport starts under navbar if I see right?

All good, really like this going unfreeze translations!:)

Screen.Recording.2021-08-31.at.13.10.12.mov

@roiLeo roiLeo requested a review from vikiival August 31, 2021 12:15
@yangwao
Copy link
Member

yangwao commented Aug 31, 2021

Ship it! 🚀

@yangwao yangwao merged commit a14a634 into kodadot:main Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new i18n structure
4 participants