-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): locales rework #656
Conversation
vous pourrez désormais parler plusieurs langues 😄
For past archival, if it would be needed for something, we can keep it or at some point it will still last in GIT history after deletion, if so we can remove it :) Okay I've checked for Slovak it's working https://deploy-preview-656--nftkodadot.netlify.app/rmrk/faq For me all good, it's looking amazing and we can finally unfreeze translations! |
Yes please ❤️ |
Oh, one last question @roiLeo What about adding that foldable effect? So whenever one searching for a question, one don't need to see all answers
|
Let's make it a separated good first issue :) |
@yangwao I didn't know if it was still relevant but I can propose something. I still got one issue (Warning) that I can't fix "Detected usage of the any type" on i18n.ts file. |
Yeah, I mean, rather wait and accept it once it's working, it will be huge upgrade for FAQs :)
That sounds like typescript warning 🤔 |
I mean looks good, I would
All good for me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work.
maybe rename src/components/rmrk/Faq-rework.vue into FAQ or so ?
Awesome work.Awesome work.
ScreenshotI still have a small problem with scrolling to the anchor. (For example when you click on chevron) |
I mean, we can flex addressable later stage... All good, really like this going unfreeze translations!:) Screen.Recording.2021-08-31.at.13.10.12.mov |
Ship it! 🚀 |
In Draft should be reviewed.
This issue was a bit painful but now I'm a copy/paste master and fluent in all languages.
Let me know if we should keep .py script.
Before submitting this PR, please make sure:
Optional
PR type
What's new? (maybe part of changelog)
Reworked locales