Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New placeholder while NFT is loading #682

Merged
merged 1 commit into from
Sep 17, 2021
Merged

New placeholder while NFT is loading #682

merged 1 commit into from
Sep 17, 2021

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Sep 3, 2021

Thank you for your contribution to the KodaDot NFT gallery.

Before submitting this PR, please make sure:

  • Your code builds clean without any erros or warnigns
  • You've posted screenshot of demonstrated change in this PR
  • Merged recent default branch, main and you have no conflicts
  • Didn't break any original functionality

Optional

  • You've tested it on mobile

PR type

  • Bugfix
  • Feature
  • Refactoring

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2021

You're Pull Request scored a 0.025 out of a possible +5 on the sentiment scale. Here's a gif representation of your PR:
Boo from Monsters Inc blinking and looking into space neutrally

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2021

Gif

@roiLeo
Copy link
Contributor

roiLeo commented Sep 3, 2021

Does it look good on Gallery ?

@vikiival
Copy link
Member Author

vikiival commented Sep 3, 2021

It’s only in gallery detail

@yangwao
Copy link
Member

yangwao commented Sep 3, 2021

👀🥨
image

@yangwao
Copy link
Member

yangwao commented Sep 16, 2021

What about this 👀

@vikiival vikiival closed this Sep 17, 2021
@vikiival vikiival deleted the new-placeholder branch September 17, 2021 10:30
@yangwao
Copy link
Member

yangwao commented Sep 17, 2021

I guess, maybe @roiLeo can look at that, I'm happy to test it one more time to have it there for bigger assets would be definitely great than the boring K logo 😄

@yangwao yangwao restored the new-placeholder branch September 17, 2021 15:02
@yangwao yangwao reopened this Sep 17, 2021
@github-actions
Copy link
Contributor

Gif

@yangwao
Copy link
Member

yangwao commented Sep 17, 2021

works
image

@yangwao yangwao merged commit 5fb39c1 into main Sep 17, 2021
@vikiival vikiival deleted the new-placeholder branch November 12, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants