Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gallery): query to hide burned nft #691

Merged
merged 8 commits into from
Sep 7, 2021

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Sep 3, 2021

I'm using for test :

  • /rmrk/u/FUEGFWoPPtX4XkRzEnZnMgwGKENscHXAiEZy6kcgaDz1BY6
  • /rmrk/collection/800f8a914281765a7d-KITTY

Before submitting this PR, please make sure:

  • Code builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I didn't break any original functionality

Optional

  • I've tested it on mobile and everything works

PR type

  • Feature

What's new? (maybe part of changelog)

  • closes Do not show burned NFTs in the UI #679 related
  • removed burned nft from Gallery
  • removed burned nft from User Collection
  • removed burned nft from Profile "Created"
  • removed burned nft from Profile "Collected"
  • removed burned nft from Profile "Sold"

Let me know if I've missed any UI that is showing burned nft.

@yangwao
Copy link
Member

yangwao commented Sep 3, 2021

Don't forget to add url to profile where you are testing it.
nft.kodadot.xyz one vs how it looks on PR to quick check :)

@vikiival
Copy link
Member

vikiival commented Sep 3, 2021

Yup this could work! Good job

@yangwao yangwao marked this pull request as ready for review September 5, 2021 09:57
@yangwao
Copy link
Member

yangwao commented Sep 5, 2021

@roiLeo others are there or are we waiting to be made? just curious! :)

removed burned nft from User Collection
removed burned nft from Profile "Collected"
removed burned nft from Profile "Sold"

@yangwao yangwao marked this pull request as draft September 5, 2021 09:58
@roiLeo
Copy link
Contributor Author

roiLeo commented Sep 5, 2021

@roiLeo others are there or are we waiting to be made? just curious! :)

removed burned nft from User Collection
removed burned nft from Profile "Collected"
removed burned nft from Profile "Sold"

Yup, this needs to be done. I will push some changes soon.

@roiLeo roiLeo marked this pull request as ready for review September 6, 2021 08:38
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but the implementation is really good here

src/queries/collectionById.graphql Show resolved Hide resolved
src/queries/collectionById.graphql Show resolved Hide resolved
@yangwao
Copy link
Member

yangwao commented Sep 7, 2021

paid out using our transfer by @prachi00 ;)
image

@yangwao yangwao merged commit b541732 into kodadot:main Sep 7, 2021
@roiLeo roiLeo deleted the feature/gallery/hideBurnedNFT branch September 7, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not show burned NFTs in the UI
3 participants