feat(collection): status signaling #724
Conversation
There was a problem hiding this comment.
Really nice work.
I would just move view to the separated .vue file along with the getters 👁️
Also I would move filtering to the graphql
https://doc.subquery.network/de/create/graphql/#json-type
|
|
||
| get collectionTradedVol() { | ||
| return this.nfts | ||
| .map(nft => nft.events.filter((e: { interaction: string; }) => e.interaction === 'BUY')) |
There was a problem hiding this comment.
I would make this piece of code reusable
|
Should I create a new component (CollectionActivity) with "collection.nft" as prop ? or move code into GalleryCardList ? |
Yes please :) Edit: |
|
All good, only 24h volume traded is missing, should we wait for the next commit or will for another PR? @roiLeo 👀😄 |
|
Tested on Kitty I need more test case Screenshot
|
I guess, let's push it and we will see how it goes? :) I guess we will receive some feedback as well. |
Tested on:
PR type
Before submitting this PR, please make sure:
Optional
What's new? (may be part of changelog)
Screenshot
Notes
In this PR i've edited some typescript file to fix building errors/warnings and I don't know if it break something.
24h volume traded feels weird :/