Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 rubickV9 #7373

Closed
wants to merge 1 commit into from
Closed

🔧 rubickV9 #7373

wants to merge 1 commit into from

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Sep 26, 2023

⚠️ Please close this PR if the rmrk chain is allright

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

Screenshot 📸

  • My fix has changed UI

Copilot Summary

🤖 Generated by Copilot at 2255d57

Added RMRK NFT support by changing the GraphQL endpoint and client configuration in utils/constants.ts.

🤖 Generated by Copilot at 2255d57

We summon the power of RMRK
To unleash our NFTs in the dark
We change the URLS.rubick and the apolloClientConfig
To connect with the GraphQL endpoint of the gods

@vikiival vikiival requested a review from a team as a code owner September 26, 2023 13:18
@vikiival vikiival requested review from preschian and daiagi and removed request for a team September 26, 2023 13:18
@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 2255d57
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6512da0a4415e70008f01d52
😎 Deploy Preview https://deploy-preview-7373--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 26, 2023

AI-Generated Summary: This pull request, titled ":wrench: rubickV9", makes a couple of changes to the URL definitions and Apollo client configuration within the utils/constants.ts file. The URL link associated with rubick has been updated to a new version, shifting from 'https://squid.subsquid.io/rubick/graphql' to 'https://squid.subsquid.io/rubick/v/v9/graphql'. Additionally, a new configuration, rmrk, has been added to the apolloClientConfig object where URLS.koda.rubick is used as the endpoint.

@reviewpad reviewpad bot added the small Pull request is small label Sep 26, 2023
@codeclimate
Copy link

codeclimate bot commented Sep 26, 2023

Code Climate has analyzed commit 2255d57 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 26, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prury
Copy link
Member

prury commented Sep 26, 2023

this happens when RMRK2 -> explore items -> uncheck buynow
image

not always tho, prob unrelated, refreshed again and it seems solved

edit: will test again in a few mins

@prury
Copy link
Member

prury commented Sep 26, 2023

images taking a bit longer to load but rmrk1 and 2 seems ok

@vikiival
Copy link
Member Author

this is for rmrk chain

@prury
Copy link
Member

prury commented Sep 26, 2023

rmrk:
images on explore items load ✔️
images inside collections load ✔️
collection banners load ✔️
(landing) top collections won't load ❌
(landing) spotlight missing results ❌
newest list ✔️
latest sales ✔️
more from this collection ✔️

Different results count:

Deployed version:

Canary(has more):

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vikiival
Copy link
Member Author

image

@vikiival
Copy link
Member Author

Thanks @prury for testing, squid will be removed

@vikiival vikiival closed this Sep 28, 2023
@vikiival vikiival deleted the rubick-v-9 branch September 28, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants