Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom metadata component #740

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Custom metadata component #740

merged 2 commits into from
Sep 17, 2021

Conversation

vikiival
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery.
Let's do a quick check before the merge.
Your contribution will be an eternal part of the community codebase.

PR type

  • Bugfix
  • Feature
  • Refactoring

Screenshot

Screenshot 2021-09-17 at 15 21 19

Screenshot 2021-09-17 at 15 21 25

@vikiival vikiival added the A-statemine-ahk related for statemine common chain, under new name Asset Hub Kusama label Sep 17, 2021
@github-actions
Copy link
Contributor

You're Pull Request scored a 0.025 out of a possible +5 on the sentiment scale. Here's a gif representation of your PR:
Boo from Monsters Inc blinking and looking into space neutrally

@github-actions
Copy link
Contributor

Gif

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code look good to me.
CustomAttributeInput isn't used in project right now ?

src/components/rmrk/Create/AttributeInput.vue Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Gif

@vikiival
Copy link
Member Author

CustomAttributeInput isn't used in project right now ?

I need primary for the Statemine integration.
But there was a request to have custom attributes for NFTs

@vikiival vikiival merged commit 1a87ce0 into main Sep 17, 2021
@vikiival vikiival deleted the 575-custom-metadata branch September 17, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-statemine-ahk related for statemine common chain, under new name Asset Hub Kusama
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants