Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#457 Adding tip in user profile #748

Merged
merged 6 commits into from
Sep 23, 2021
Merged

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Sep 18, 2021

Thank you for your contribution to the KodaDot NFT gallery.
Let's do a quick check before the merge.
Your contribution will be an eternal part of the community codebase.

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting this PR, please make sure:

  • Code builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it on mobile and everything works
  • I found edge cases

What's new? (may be part of changelog)

  • This PR closes Add tip jar on user profile  #457
    I have added a 'Gift 10$' button in artist's profile and on clicking that I take them to /transfer with values pre filled. I have also added profile information for artist so the user knows who he is paying.

If issue had bounty label ($,$$,$$$)

Community participation

Screenshot

  • Whenever my fix has changed something on UI, a screenshot for others, is more than welcome

Screenshot 2021-09-18 at 2 49 23 PM

Screenshot 2021-09-18 at 2 53 36 PM

Screenshot 2021-09-21 at 10 42 13 PM

@yangwao
Copy link
Member

yangwao commented Sep 19, 2021

I would probably put in way, so it's in same place everytime
image
image

I would change it to "Sent for Sign"
image

After being sent, it generated a link to https://kusama.subscan.io/extrinsic/0xff78499a69e974943f47c009d2b9718f489bc5e631b6a0ae8f99ec7c6817c184
image
Where right link to extrinsic is https://kusama.subscan.io/extrinsic/0x8f7580c1dc34d6cf300f1e645d9af74b8f0864de6c8b48a3300ebacbf90a9ef6

Otherwise good experience, I would note down to tell the user in something like
"Congratulations for supporting <artist_name>, now let's tweet about it" with link to help construct a tweet with transactions inside for example to drive engagement

@yangwao
Copy link
Member

yangwao commented Sep 21, 2021

@prachi00 let's finish this so we can push it to production :)

@prachi00
Copy link
Member Author

@yangwao for the transaction extrinsic being wrong we have to implement #755 first, so until that is done we should not add tweet text afterwards as it would link to the wrong subscan url.
Two issues I have resolved that you mentioned, other than the ones related to transaction extrinsic.

@prachi00
Copy link
Member Author

@yangwao I have finished this and updated the screenshot as well. Do let me know if you want to change the copy of buttons and the tweet, if they don't seem fine.

@yangwao
Copy link
Member

yangwao commented Sep 22, 2021

image

👀 Can we avoid force-push please? 🙄

@yangwao I have finished this and updated the screenshot as well. Do let me know if you want to change the copy of buttons and the tweet, if they don't seem fine.

Let me test it!

I guess I would try to make text stand out a bit from there
image

Current text there

I just helped a really cool artist by donating. Check it out here:

I would put there

I've just helped a really cool creator by donating. Check my donation proof: via @kodadot

@prachi00
Copy link
Member Author

@yangwao Have done the text changes mentioned
Screenshot 2021-09-22 at 7 45 08 PM
d

src/components/transfer/DonationButton.vue Outdated Show resolved Hide resolved
src/components/transfer/Transfer.vue Outdated Show resolved Hide resolved
src/views/Profile.vue Outdated Show resolved Hide resolved
@yangwao
Copy link
Member

yangwao commented Sep 23, 2021

let me put it live, seems there might be something missing, but 80% good, we can tune it later! 😄

Thanks @roiLeo for the review! :) Really appreciated!

@yangwao yangwao merged commit c7715eb into kodadot:main Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tip jar on user profile
3 participants