feat(series): nft top collection

[roiLeo]

⚠️ WORK IN PROGRESS ⚠️
Some of the code is dirty (Rankings/utils.ts) and need refatoring/rework.
I'm not sure if I got the right 7d% & 30d% formula (need some verification).

Brief

New page/component Rankings

PR type

• Feature

Before submitting this PR, please make sure:

• Code builds clean without any errors or warnings
• I've merged recent default branch -- main and I've no conflicts
• I've didn't break any original functionality
• I've posted screenshot of demonstrated change in this PR

Optional

• I've tested it on mobile and everything responsive doesn't work on image

Need to test

• verification of volume price
• verification of floor price
• verification of 7d%/30d% data

Rework

• 7d%/30d% Formula:
  As if t_0 (price now) & t_7 (price 7d ago) so:
  price_change(%) = ((price(t_0) - price(t_24)) / price(t_0)) * 100

What's new? (may be part of changelog)

• Rankings on Collectibles #586 related
• Ranking on collections // collectibles #587

Screenshot

[vikiival]

Maybe check the speed of the app with and without await here

[roiLeo]

same speed with and without ~3800ms

[yangwao]

Added right issue to desc #587 however #586 was just initial draft 😄

[yangwao]

Should we start testing it? 👀
This will be rocket fuel for KodaDot 🚨

[roiLeo]

Should we start testing it? 👀 This will be rocket fuel for KodaDot 🚨

Well, problem is %7d & %30d stats seems wrong as they will always be green or null.
Currently to calculate percentage over 7 days, I compare traded volume over 7 days on total volume, this will never be negative.

[yangwao]

I would add addressable rows to address-bar, ?rows=100 ? :)

[yangwao]

I was thinking if we could make it more asynchronously, so each row would be own query to have it feel less blocking on frontend?

Or Viki proposed just fetch name of collections and then fetch data for collections as separate query?

[roiLeo]

I was thinking if we could make it more asynchronously, so each row would be own query to have it feel less blocking on frontend?

Or Viki proposed just fetch name of collections and then fetch data for collections as separate query?

I don't think this will resolve loading time. IMO, problem comes from the query that returns all the data, to reduce it we could sort by rank directly from graphql query and add pagination (first & offset).

[yangwao]

Let's experiment with that :) Anything that could help put loading times down 👌

…

On Fri, Oct 1, 2021, 17:13 roiLeo ***@***.***> wrote: I was thinking if we could make it more asynchronously, so each row would be own query to have it feel less blocking on frontend? Or Viki proposed just fetch name of collections and then fetch data for collections as separate query? I don't think this will resolve loading time. IMO, problem comes from the query that returns all the data, to reduce it we could sort by rank directly from graphql query and add pagination (first & offset). — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#803 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABM5POOMQ2UWBNJKUBCUEB3UEXF3HANCNFSM5EZY2RFA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[yangwao]

Oh re: naming
We've been chatting about the naming of this feature.
We've agreed that we would go with
SERIES on nav and URL could be /series-insights

[yangwao]

Checking on verifications, is that okayish or still needs to be checked?

Need to test

• verification of volume price
• verification of floor price
• verification of 7d%/30d% data

Checking what's left important from issue #587

Would be good to have

• Number of different owners

Then is ready to fly, for silent update for now, so ppl can verify it is playing all right 👌 😄

[yangwao]

LGTM