Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App should correctly show fullscreen #814

Merged
merged 4 commits into from
Sep 28, 2021
Merged

App should correctly show fullscreen #814

merged 4 commits into from
Sep 28, 2021

Conversation

vikiival
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery,
we really appreciate your contribution!

PR type

  • Bugfix
  • Feature
  • Refactoring

Before submitting this PR, please make sure:

  • Your code builds clean without any erros or warnigns
  • You've posted screenshot of demonstrated change in this PR
  • Merged recent default branch, main and you have no conflicts
  • Didn't break any original functionality

Optional

  • You've tested it on mobile
  • Are there any edge cases? Name if any

@vikiival vikiival marked this pull request as draft September 27, 2021 13:53
@github-actions
Copy link
Contributor

You're Pull Request scored a 0.041666666666666664 out of a possible +5 on the sentiment scale. Here's a gif representation of your PR:
Boo from Monsters Inc blinking and looking into space neutrally

@github-actions
Copy link
Contributor

Gif

@github-actions
Copy link
Contributor

Gif

@vikiival vikiival marked this pull request as ready for review September 27, 2021 14:50
@github-actions
Copy link
Contributor

Gif

roiLeo
roiLeo approved these changes Sep 27, 2021
View reviewed changes
src/components/rmrk/Media/ImageMedia.vue Outdated Show resolved Hide resolved
src/components/rmrk/Gallery/GalleryItem.vue Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Gif

@vikiival
Copy link
Member Author

Fix'd 🎸

@vikiival vikiival merged commit c720298 into main Sep 28, 2021
@vikiival vikiival deleted the 813-full-screen branch September 28, 2021 08:04
@vikiival vikiival mentioned this pull request Sep 28, 2021
Closed
@roiLeo roiLeo mentioned this pull request Nov 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@yangwao yangwao Awaiting requested review from yangwao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vikiival @roiLeo