Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(profile): add pagination & current tab on url #828

Merged
merged 2 commits into from
Oct 1, 2021
Merged

feat(profile): add pagination & current tab on url #828

merged 2 commits into from
Oct 1, 2021

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Oct 1, 2021 •
edited
Loading

PR type

  • Feature

Before submitting this PR, please make sure:

  • Code builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've didn't break any original functionality

Optional

  • I found edge cases: Error: "Avoided redundant navigation to current location"

What's new? (may be part of changelog)

Testable link

@vikiival vikiival self-requested a review October 1, 2021 07:30
@yangwao
Copy link
Member

yangwao commented Oct 1, 2021

This is lovely!

@yangwao yangwao merged commit 610bde3 into kodadot:main Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival Awaiting requested review from vikiival

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add addressable paging to the creator profile
2 participants
@roiLeo @yangwao