Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Holder of drop page iteration #9027

Merged
merged 38 commits into from
Feb 1, 2024
Merged

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Jan 17, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Needs Design check

Context

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

connect wallet

CleanShot 2024-01-17 at 14 06 02@2x

requirements not met

CleanShot 2024-01-17 at 14 07 20@2x

ready to mint

CleanShot 2024-01-17 at 14 05 24@2x

CleanShot 2024-01-18 at 14 40 16@2x

@kodabot
Copy link
Collaborator

kodabot commented Jan 17, 2024

SUCCESS @hassnian PR for issue #8886 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit bc2b1c8
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65bb83a72748d9000999ed1d
😎 Deploy Preview https://deploy-preview-9027--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

reviewpad bot commented Jan 17, 2024

AI-Generated Summary: This pull request introduces changes that aim to enhance the NFT minting process. Some notable modifications include:

  • Updating a conditional logic to reflect a more accurate state.
  • Updating datatypes to reflect and enforce correct usage.
  • Inclusion of a new "checkIfAlreadyClaimed" function that uses the "isNftClaimed" function to check if the NFT has already been claimed.
  • Updating the structure of certain properties (for example, "holderOfCollection") to provide more context.
  • Addition of computed properties to check certain conditions such as "mintedAmountForCurrentUser" and "maxMintLimitForCurrentUser".
  • Introducing "HolderOfCollectionMintRequirements.vue" and "MintRequirementItem.vue" components to break down the minting requirements.
  • Renaming some key properties and updating related function calls.
  • Modifying the locale file to include newer translation strings.

@reviewpad reviewpad bot added the large Pull request is large label Jan 17, 2024
@hassnian hassnian marked this pull request as ready for review January 17, 2024 09:13
@hassnian hassnian requested a review from a team as a code owner January 17, 2024 09:13
@hassnian hassnian requested review from preschian and Jarsen136 and removed request for a team January 17, 2024 09:13
@prury
Copy link
Member

prury commented Jan 29, 2024

I have one account that had previously minted one chroma using a motherboard nft, then i asked Exez to lend me one of his motherboard NFTs to check if i could be eligible to mint another Chroma.

my account:
https://deploy-preview-9027--koda-canary.netlify.app/ahp/u/13s37n7Y9VvoF1JcqnQzbL2b76qb9vNQQyXvpvpProdrpvBe

NFT he lended to me: https://canary.kodadot.xyz/ahp/gallery/50-357

yet it does not identify that i have a second motherboard nft:

image

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jan 29, 2024
@hassnian
Copy link
Contributor Author

hassnian commented Jan 30, 2024

I have one account that had previously minted one chroma using a motherboard nft, then i asked Exez to lend me one of his motherboard NFTs to check if i could be eligible to mint another Chroma.

my account: https://deploy-preview-9027--koda-canary.netlify.app/ahp/u/13s37n7Y9VvoF1JcqnQzbL2b76qb9vNQQyXvpvpProdrpvBe

NFT he lended to me: https://canary.kodadot.xyz/ahp/gallery/50-357

yet it does not identify that i have a second motherboard nft:

@prury from what I can see logic was ok, both nfts are claimed, as per the design availabe for mint count should be visible even after a drop is minted out (fixed mb)

check again

also changed a bit chain balance code which affected teleport page and autotelport (any modal where is used will be the same ) , tested it on my end works fine, could you test that on your end ?

thanks

CleanShot 2024-01-30 at 09 58 59@2x

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked S-resolve-merge-conflicts-🤝 and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Jan 30, 2024
@yangwao
Copy link
Member

yangwao commented Jan 31, 2024

image
let's resolve conflicts @hassnian and merge it as it's getting old PR

@vikiival has a point that would need in future to reflect new API with a new worker (which is not done yet)

@vikiival
Copy link
Member

It is non-blocking - https://github.com/kodadot/private-workers/issues/43

@newraina newraina mentioned this pull request Feb 1, 2024
@yangwao
Copy link
Member

yangwao commented Feb 1, 2024

Probably will go to another release or @hassnian if you can resolve conflicts under 30 min? :D

@hassnian
Copy link
Contributor Author

hassnian commented Feb 1, 2024

Probably will go to another release or @hassnian if you can resolve conflicts under 30 min? :D

on it

@yangwao
Copy link
Member

yangwao commented Feb 1, 2024

love the energy

Copy link

codeclimate bot commented Feb 1, 2024

Code Climate has analyzed commit bc2b1c8 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yangwao
Copy link
Member

yangwao commented Feb 1, 2024

Thanks!
pay 80 usd

@yangwao yangwao merged commit 7077654 into kodadot:main Feb 1, 2024
13 of 14 checks passed
@yangwao
Copy link
Member

yangwao commented Feb 1, 2024

😍 Perfect, I’ve sent the payout
💵 $80 @ 6.64 USD/DOT ~ 12.048 $DOT
🧗 16faLfsywwNATaEfbH2ah75dn6ZmctQWpMS5G4KFhbmj5hnD
🔗 0x8b1da8b504aaf351c8fd30d1f7aac2ebd2ec635668256f984bc45674a55b0744

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Holder of drop page iteration
8 participants