Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump @nuxtjs/sitemap version #9140

Merged
merged 2 commits into from
Jan 26, 2024
Merged

chore: bump @nuxtjs/sitemap version #9140

merged 2 commits into from
Jan 26, 2024

Conversation

preschian
Copy link
Member

@preschian preschian commented Jan 26, 2024

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Currently, this is the root cause of the renovate throw error. try to run this command on main branch:

npx nuxi upgrade -f && NITRO_PRESET=cloudflare_pages pnpm nuxi build

now, try to run that command again in this branch

Did your issue had any of the "$" label on it?

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit a8077d6
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65b32eb56570070008e1e5f5
😎 Deploy Preview https://deploy-preview-9140--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

reviewpad bot commented Jan 26, 2024

AI-Generated Summary: This pull request includes updates to both the package.json and nuxt.config.ts files. In the package.json file, changes involve swapping the "nuxt-simple-sitemap" package for the "@nuxtjs/sitemap" package indicating a shift in the method for the generation of sitemaps. In the nuxt.config.ts file, the previous 'nuxt-simple-sitemap' module was replaced with the '@nuxtjs/sitemap' module. This suggests that the sitemap has been migrated to a more advanced, possibly feature-rich version provided by the NuxtJS team. Additionally, the hooks for sitemap generation have been removed, which implies reliance on the capabilities of the newly integrated '@nuxtjs/sitemap' module, rather than managing it programmatically through the hook.

@reviewpad reviewpad bot added the large Pull request is large label Jan 26, 2024
Copy link
Contributor

reviewpad bot commented Jan 26, 2024

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 6505 lines exceeds the maximum allowed for the inline comments feature.

Copy link

codeclimate bot commented Jan 26, 2024

Code Climate has analyzed commit a8077d6 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Jan 26, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Native code npm/bufferutil@4.0.8

View full report↗︎

Next steps

What's wrong with native code?

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/bufferutil@4.0.8

@preschian preschian marked this pull request as ready for review January 26, 2024 04:09
@preschian preschian requested a review from a team as a code owner January 26, 2024 04:09
@preschian preschian requested review from roiLeo and Jarsen136 and removed request for a team January 26, 2024 04:09
@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jan 26, 2024
@yangwao
Copy link
Member

yangwao commented Jan 26, 2024

Thanks!
pay 30 usd

@yangwao yangwao merged commit d602260 into main Jan 26, 2024
14 of 15 checks passed
@yangwao yangwao deleted the chore-bump-sitemap branch January 26, 2024 13:39
@yangwao
Copy link
Member

yangwao commented Jan 26, 2024

😍 Perfect, I’ve sent the payout
💵 $30 @ 6.55 USD/DOT ~ 4.58 $DOT
🧗 1xjvRADwdJcnmUCLWerEHR4iGCT5EBTm4D4fzLLg4LcAC9p
🔗 0x0146f636c2de2f02ef9f5997674a1d8daf5006b1b36be1f186b46e81281e6885

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 26, 2024
This was referenced Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants