Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 is-relative to tailwind #9187

Merged
merged 2 commits into from
Jan 30, 2024
Merged

🔧 is-relative to tailwind #9187

merged 2 commits into from
Jan 30, 2024

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jan 30, 2024

⚠️ note that some of the components might need !important

@roiLeo roiLeo requested a review from a team as a code owner January 30, 2024 08:18
@roiLeo roiLeo requested review from preschian and Jarsen136 and removed request for a team January 30, 2024 08:18
@netlify Netlify
Copy link

netlify bot commented Jan 30, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 314e443
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65b92d62cc3f630008a49921
😎 Deploy Preview https://deploy-preview-9187--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@roiLeo roiLeo requested a review from prury January 30, 2024 08:18
@reviewpad Reviewpad
Copy link
Contributor

reviewpad bot commented Jan 30, 2024

AI-Generated Summary: This pull request includes code refactoring in multiple components. It mainly modifies the class 'is-relative' to 'relative' in several Vue.js components, in possibly an attempt to align the class naming convention with the Tailwind CSS framework. This change affects 16 different components including CollectionDetail, CreateLanding, CreateNft, FilterMenuButton, GalleryItem, HeroBanner, SignupBanner, and others. Make sure this change does not affect the functioning or appearance of these components, as the 'is-relative' class might have been defined differently than the 'relative' class in Tailwind CSS.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jan 30, 2024
@reviewpad Reviewpad
Copy link
Contributor

reviewpad bot commented Jan 30, 2024

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed waiting-for-review labels Jan 30, 2024
@codeclimate CodeClimate
Copy link

codeclimate bot commented Jan 30, 2024

Code Climate has analyzed commit 314e443 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code

See analysis details on SonarCloud

@roiLeo roiLeo added this pull request to the merge queue Jan 30, 2024
Merged via the queue into kodadot:main with commit e02209b Jan 30, 2024
15 checks passed
@roiLeo roiLeo deleted the chore/tailwind/relative branch January 30, 2024 17:36
This was referenced Feb 1, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@prury prury prury approved these changes

Assignees
No one assigned
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roiLeo @preschian @Jarsen136 @prury