Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace is-flex-* with tailwind equivalent #9205

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 requested a review from a team as a code owner January 31, 2024 03:29
@Jarsen136 Jarsen136 requested review from preschian and roiLeo and removed request for a team January 31, 2024 03:29
Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 243deed
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65b9f8db9358630008233743
😎 Deploy Preview https://deploy-preview-9205--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Jan 31, 2024

SUCCESS @Jarsen136 PR for issue #9190 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jan 31, 2024
Copy link
Contributor

reviewpad bot commented Jan 31, 2024

AI-Generated Summary: This pull request introduces a series of refactorings across multiple Vue.js components. It replaced various class names throughout the project corresponding to changing CSS definitions. This has been done to streamline CSS classes and eliminate redundancy.

Changes can be broadly detailed as follows:

  1. Replaced is-justify-content-center and is-align-items-center classes with justify-center and items-center respectively.
  2. Modified is-justify-content-space-between to justify-between.
  3. Replaced classes is-flex and is-flex-direction-column with flex and flex-col respectively.

The refactoring was spread across 8 components including, Activity.vue, GenerativeLayout.vue, HolderOfCollection.vue, GalleryItemHolderOf.vue, and others in the /components directory.

The patch comprises of 3 separate commits to allow a more granular understanding of the changes being made.

components/profile/CollectionFilter.vue Outdated Show resolved Hide resolved
components/profile/CollectionFilter.vue Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Jan 31, 2024

Code Climate has analyzed commit 243deed and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

@roiLeo roiLeo added this pull request to the merge queue Jan 31, 2024
Merged via the queue into kodadot:main with commit 5d30dec Jan 31, 2024
15 checks passed
This was referenced Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace is-flex with tailwind equivalent
4 participants