Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Teleport - checking funds visual bug #9206

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Jan 31, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Needs QA check

  • @kodadot/qa-guild please review

@prury also check the main buttin text

CleanShot 2024-01-31 at 10 27 43@2x

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2024-01-31 at 11 05 55@2x

CleanShot.2024-01-31.at.11.03.30.mp4

@hassnian hassnian requested a review from a team as a code owner January 31, 2024 05:26
@hassnian hassnian requested review from preschian and Jarsen136 and removed request for a team January 31, 2024 05:26
Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 2c74721
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65b9da442f48c20008dcc729
😎 Deploy Preview https://deploy-preview-9206--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Jan 31, 2024

SUCCESS @hassnian PR for issue #9193 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link
Contributor

reviewpad bot commented Jan 31, 2024

AI-Generated Summary: This pull request includes changes to the 'AutoTeleportModal.vue' file. The alterations aim to improve the functioning of auto teleport modal by fixing the issue regarding checking funds loading after a successful buy.

The activeStep variable declaration has been updated and brought after isModalActive, while the calculation of checkBalanceState has been restructured and renamed as balanceCheckState.

The status computation code has been moved inside a watch function for better reactivity, ensuring the balance check status updates appropriately when the status of teleport transaction finalizes or the ability to do an action changes.

Some other values like hasActions and hasCompletedBalanceCheck were also revised for their variable assignments. Extra attention was given to the conditions while returning the btnLabel value and a watch function was also added to manage the state of balanceCheckState.

Overall, this patch aims to improve the user interface by monitoring specific conditions and changing the status of certain steps accordingly.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jan 31, 2024
Copy link

codeclimate bot commented Jan 31, 2024

Code Climate has analyzed commit 2c74721 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed waiting-for-review labels Jan 31, 2024
@yangwao
Copy link
Member

yangwao commented Feb 1, 2024

thanks!
pay 20 usd

@yangwao yangwao merged commit c903d37 into kodadot:main Feb 1, 2024
15 checks passed
@yangwao
Copy link
Member

yangwao commented Feb 1, 2024

😍 Perfect, I’ve sent the payout
💵 $20 @ 6.64 USD/DOT ~ 3.012 $DOT
🧗 16faLfsywwNATaEfbH2ah75dn6ZmctQWpMS5G4KFhbmj5hnD
🔗 0x9c4f0f866b5f9c6fefad4bcd9df8019ad3f90c5c58bcd11882ce51bef7bd86b4

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Feb 1, 2024
This was referenced Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Teleport - checking funds visual bug
6 participants