Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Extremely lucky breakpoint #9358

Merged
merged 3 commits into from
Feb 14, 2024
Merged

fix: Extremely lucky breakpoint #9358

merged 3 commits into from
Feb 14, 2024

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Feb 10, 2024

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image

Copilot Summary

copilot:summary

copilot:poem

@Jarsen136 Jarsen136 requested a review from a team as a code owner February 10, 2024 15:06
@Jarsen136 Jarsen136 requested review from preschian and roiLeo and removed request for a team February 10, 2024 15:06
@kodabot
Copy link
Collaborator

kodabot commented Feb 10, 2024

SUCCESS @Jarsen136 PR for issue #9354 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link

netlify bot commented Feb 10, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 9fb81e4
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65cbf7f125ace90008bd85bb
😎 Deploy Preview https://deploy-preview-9358--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Feb 12, 2024
@prury
Copy link
Member

prury commented Feb 12, 2024

i think it may have broken mobile smaller sizes:

mobile-broke.mp4

@exezbcz
Copy link
Member

exezbcz commented Feb 12, 2024

image

this does not look good

IMO solution would be to reduce the card amount and stretch the others

@Jarsen136
Copy link
Contributor Author

IMO solution would be to reduce the card amount and stretch the others

It make sense. Updated

@prury prury removed the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Feb 13, 2024
@prury
Copy link
Member

prury commented Feb 13, 2024

@Jarsen136

something that wasn't happening before(last drop card gets cutted):

image

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Feb 13, 2024
@Jarsen136
Copy link
Contributor Author

Jarsen136 commented Feb 13, 2024

@Jarsen136

something that wasn't happening before(last drop card gets cutted):

It's not getting "cutted", but showing less cards on the small screen. There are some screenshots for different size screen.

image image image image

@prury
Copy link
Member

prury commented Feb 13, 2024

@Jarsen136
something that wasn't happening before(last drop card gets cutted):

It's not getting "cutted", but showing less cards on the small screen. There are some screenshots for different size screen.

lol, cutted does not exist my bad, getting cut
its only the last one tho, can you check?

@Jarsen136
Copy link
Contributor Author

@Jarsen136
something that wasn't happening before(last drop card gets cutted):

It's not getting "cutted", but showing less cards on the small screen. There are some screenshots for different size screen.

lol, cutted does not exist my bad, getting cut its only the last one tho, can you check?

Oh you are talking about the gap between the last card and the edge of the screen. It happens on every carousel list by the way. For example, you could see the gap at the latest sales on landing. If I remember correct, we had an issue for this UI change.

image

@prury
Copy link
Member

prury commented Feb 13, 2024

Oh you are talking about the gap between the last card and the edge of the screen. It happens on every carousel list by the way. For example, you could see the gap at the latest sales on landing. If I remember correct, we had an issue for this UI change.

is this actually: check the last one(Alchemy)(first video is canary)

cut.mp4

Copy link

codeclimate bot commented Feb 13, 2024

Code Climate has analyzed commit 9fb81e4 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Feb 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

@Jarsen136
Copy link
Contributor Author

Oh you are talking about the gap between the last card and the edge of the screen. It happens on every carousel list by the way. For example, you could see the gap at the latest sales on landing. If I remember correct, we had an issue for this UI change.

is this actually: check the last one(Alchemy)(first video is canary)

cut.mp4

Thanks for the video, I fixed it.

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Feb 14, 2024
@yangwao
Copy link
Member

yangwao commented Feb 14, 2024

Thanks!
pay 30 usd

@yangwao yangwao merged commit dad8a4e into kodadot:main Feb 14, 2024
14 checks passed
@yangwao
Copy link
Member

yangwao commented Feb 14, 2024

😍 Perfect, I’ve sent the payout
💵 $30 @ 7.65 USD/DOT ~ 3.922 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0xbed9cce1c8f96cdd665464922fa5f097496750740351802d01c2e06522c35a08

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Feb 14, 2024
This was referenced Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extremely lucky breakpoint
7 participants