Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the SDKs to the stable Protocol 20 release #341

Closed
Shaptic opened this issue Oct 23, 2023 · 5 comments · Fixed by #343
Closed

Updating the SDKs to the stable Protocol 20 release #341

Shaptic opened this issue Oct 23, 2023 · 5 comments · Fixed by #343

Comments

@Shaptic
Copy link

Shaptic commented Oct 23, 2023

SDKs need to be updated to adapt to breaking changes that have occurred since Preview 11 (i.e. the current testnet release candidate) coming to Protocol 20.

Summary of Breaking Changes

This is likely irrelevant to SDK maintainers, but do note sandbox mode has been removed from the Soroban CLI (stellar/stellar-cli#983).

XDR

The XDR needs to be updated to stellar/stellar-xdr@6a620d1. This includes a non-trivial list of breaking changes (mostly renames):

  • The BumpFootprintExpirationOp is now ExtendFootprintTTLOp and its ledgersToExpire field is now named extendTo, but it serves the same purpose.
  • ContractExecutable.contractExecutableToken is now contractExecutableStellarAsset
  • SorobanTransactionData.refundableFee is now resourceFee
  • This new fee encompasses the entirety of the Soroban-related resource fees. Note that this is distinct from the "network-inclusion" fee that you would set on your transaction
  • see Upgrade XDR to the final, stable testnet version. stellar/js-stellar-base#704 for an example migration

RPC

@Ifropc
Copy link

Ifropc commented Oct 24, 2023

@EdwinGuayacan FYI, in case you missed this ^
XDR and RPC are stable for protocol version 20, and we expect it to be ready for testnet release! (Unless there is a critical bug found)
It would be great if you could let us know some estimates on when you expect the SDK to be up to date with the protocol changes. Thank you!

@Shaptic
Copy link
Author

Shaptic commented Oct 25, 2023

There is an additional schema change: the getLedgerEntries RPC response will use liveUntilLedgerSeq rather than expirationLedgerSeq in the final build (ref: stellar/stellar-cli#1029)

@miguelnietoa
Copy link
Member

The changes have been implemented and will be released once the next Soroban release comes out!

Here are the PRs where the changes have been applied:

Thank you @Shaptic @Ifropc

@Ifropc
Copy link

Ifropc commented Dec 11, 2023

Hi @miguelnietoa just a heads-up, new quickstart image has been released couple days ago stellar/quickstart:soroban-dev and is updated to match futurenet and has all the p20 stable versions
So it should be available to test against

@miguelnietoa
Copy link
Member

Hi @Ifropc, We are about to start testing again and do release once we confirm everything is working well. 😉
Thank u!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants