Upgrade XDR to the final, stable testnet version. #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -2.92 kB (0%) Total Size: 3.16 MB
|
Shaptic
force-pushed
the
bump-stable-xdr
branch
2 times, most recently
from
67d7936
to
4d27d93
Compare
Shaptic
force-pushed
the
bump-stable-xdr
branch
from
963db6f
to
10588aa
Compare
10 tasks
sreuland
reviewed
Oct 16, 2023
sreuland
approved these changes
Oct 16, 2023
Shaptic
changed the title
Shaptic
changed the title
This was referenced Oct 23, 2023
Shaptic
added a commit
that referenced
this pull request
Dec 5, 2023
…#710) * Upgrade XDR to the final, stable testnet version. (#704, #715) XDR has been upgraded to the latest stable version. This is mostly renames, but it includes the following relevant breaking changes: - `Operation.bumpFootprintExpiration` is now `extendFootprintTtl` and its `ledgersToExpire` field is now named `extendTo`, but it serves the same purpose. - `xdr.ContractExecutable.contractExecutableToken` is now `contractExecutableStellarAsset` - `xdr.SorobanTransactionData.refundableFee` is now `resourceFee` - In turn, `SorobanDataBuilder.setRefundableFee` is now `setResourceFee` - This new fee encompasses the entirety of the Soroban-related resource fees. Note that this is distinct from the "network-inclusion" fee that you would set on your transaction (i.e. `TransactionBuilder(..., { fee: ... })`). - In TypeScript, the `Operation.BumpFootprintExpiration` is now `Operation.ExtendFootprintTtl` Commit: stellar/stellar-xdr @ bb54e50 * Add helpful abstractions for common invocation types. (#703) * Drop incorrect key entry for contract footprint (#709) * Republish package under @stellar/ scope (#714)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #699.
XDR has been upgraded to the latest stable version (stellar/stellar-xdr@6a620d1). This is mostly renames, but it includes the following relevant breaking changes:
Operation.bumpFootprintExpirationis nowextendFootprintTtland itsledgersToExpirefield is now namedextendTo, but it serves the same purpose.xdr.ContractExecutable.contractExecutableTokenis nowcontractExecutableStellarAssetxdr.SorobanTransactionData.refundableFeeis nowresourceFeeSorobanDataBuilder.setRefundableFeeis nowsetResourceFeeTransactionBuilder(..., { fee: ... })).Operation.BumpFootprintExpirationis nowOperation.ExtendFootprintTTLNote: The diffs to
src/generated/*.jsandtypes/*.d.tsshould be very readable.