Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Analyzer-lsp should exit != 0 when an unknown option is passed. #453

Closed
jortel opened this issue Dec 20, 2023 · 4 comments · Fixed by #523
Closed

🐛 Analyzer-lsp should exit != 0 when an unknown option is passed. #453

jortel opened this issue Dec 20, 2023 · 4 comments · Fixed by #523
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@jortel
Copy link

jortel commented Dec 20, 2023

This will prevent silent failures when used programmatically due to integration issues.
@shawn-hurley shawn-hurley added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. labels Jan 3, 2024
@Vickysomtee
Copy link
Contributor

@jortel can you provide more context on this?

@shawn-hurley
Copy link
Contributor

shawn-hurley commented Jan 12, 2024 •
edited
Loading

@Vickysomtee I think that what you will need to do is handle when flags.Parse() returns an error.

If you want any help, please reach out on slack.

@pranavgaikwad
Copy link
Contributor

@Vickysomtee can you confirm whether your fix also addresses this issue?

@Vickysomtee
Copy link
Contributor

@pranavgaikwad No. It doesn't. I am yet to get a good understanding of this issue

@shawn-hurley shawn-hurley mentioned this issue Mar 5, 2024
Merged
shawn-hurley added a commit that referenced this issue Mar 5, 2024
@shawn-hurley
🐛 fixing logs with new command format, adding new format to dep comma…
d483bcb 
…nd (#523)

fixes #453

Signed-off-by: Shawn Hurley <shawn@hurley.page>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 fixing logs with new command format, adding new format to dep command shawn-hurley/analyzer-lsp
4 participants
@jortel @shawn-hurley @pranavgaikwad @Vickysomtee