Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Getting Code Snippet for "Python.Referenced" capability in violation incidents #506

Closed
1 task done
sravsravan-deloitte opened this issue Feb 16, 2024 · 4 comments · Fixed by #522
Closed
1 task done
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sravsravan-deloitte
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

v0.3.0

Priority

Critical

Current Behavior

Example app : https://github.com/konveyor/analyzer-lsp/tree/main/examples/python

Example Rule :

  • message: python sample rule 001
    ruleID: python-sample-rule-001
    description: "Discover testing"
    tag: ["python"]
    labels:
    • konveyor.io/source=legacy
    • konveyor.io/target=python
      when:
      python.referenced:
      location: METHOD_CALL
      pattern: "hello_world"

Associated Output:

  • name: konveyor-analysis
    tags:
    • python
      violations:
      python-sample-rule-001:
      description: Discover testing
      category: potential
      labels:
      • konveyor.io/source=legacy
      • konveyor.io/target=python
        incidents:
      • uri: file:///analyzer-lsp/examples/python/file_a.py
        message: python sample rule 001
        lineNumber: 2
        variables:
        file: file:///analyzer-lsp/examples/python/file_a.py

Expected Behavior

Code snippet should present in output under incidents block .

How Reproducible

Always (Default)

Steps To Reproduce

No response

Environment

Default

Anything else?

No response

@sravsravan-deloitte sravsravan-deloitte added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 16, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Feb 16, 2024
@pranavgaikwad
Copy link
Contributor

@sravsravan-deloitte Thank you for filing the issue. we will take a look into this.

@pranavgaikwad
Copy link
Contributor

/priority backlog
/triage accepted

@konveyor-ci-bot konveyor-ci-bot bot added priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Feb 20, 2024
@pranavgaikwad
Copy link
Contributor

@sravsravan-deloitte This should be fixed via #522

pranavgaikwad added a commit that referenced this issue Mar 4, 2024
Fixes #506

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants