Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Dependency CLI fails when there are 0 dependencies for an app #582

Closed
1 task done
pranavgaikwad opened this issue Apr 19, 2024 · 0 comments · Fixed by #583
Closed
1 task done

[BUG] Dependency CLI fails when there are 0 dependencies for an app #582

pranavgaikwad opened this issue Apr 19, 2024 · 0 comments · Fixed by #583
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v0.3.2

Comments

@pranavgaikwad
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

latest / 3.0.1

Priority

Major

Current Behavior

When there are 0 dependencies for a Java app, the dependency cli fails...

Expected Behavior

When there are 0 dependencies and no other errors, dep cli should not fail...

How Reproducible

Always (Default)

Steps To Reproduce

  1. Use any app as input that doesn't have any deps in pom.xml file
  2. Run konveyor-analyzer-dep command for this app

Environment

- **Analyzer Image SHA** latest
- **JDTLS  base image SHA** latest
- **Provider Settings JSON**

Anything else?

No response
@pranavgaikwad pranavgaikwad added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 19, 2024
@pranavgaikwad pranavgaikwad added this to the v0.3.2 milestone Apr 19, 2024
@pranavgaikwad pranavgaikwad added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Apr 19, 2024
@konveyor-ci-bot konveyor-ci-bot bot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 19, 2024
@pranavgaikwad pranavgaikwad mentioned this issue Apr 19, 2024
Merged
pranavgaikwad added a commit that referenced this issue Apr 19, 2024
@pranavgaikwad
🐛 when no dependencies are found do not return an error (#583)
20e6323 
Fixes #582

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
pranavgaikwad added a commit to pranavgaikwad/analyzer-lsp that referenced this issue Apr 22, 2024
@pranavgaikwad
🐛 when no dependencies are found do not return an error (konveyor#583)
5e7032b 
Fixes konveyor#582

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
@pranavgaikwad pranavgaikwad mentioned this issue Apr 22, 2024
Merged
pranavgaikwad added a commit that referenced this issue Apr 22, 2024
@pranavgaikwad
🐛 when no dependencies are found do not return an error (#583) (#584)
6239317 
Fixes #582

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: ✅ Done
Milestone
v0.3.2
Development

Successfully merging a pull request may close this issue.

🐛 when no dependencies are found do not return an error pranavgaikwad/analyzer-lsp
1 participant
@pranavgaikwad