Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Try pom packaging if jar packaging fails #483

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

jmle
Copy link
Contributor

@jmle jmle commented Feb 5, 2024

Fixes #482

Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
@jmle jmle changed the title Try pom packaging if jar packaging fails 🐛 Try pom packaging if jar packaging fails Feb 5, 2024
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Copy link
Contributor

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

some nits but nothing that is drastic

provider/internal/java/dependency.go Outdated Show resolved Hide resolved
provider/internal/java/dependency.go Outdated Show resolved Hide resolved
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
@shawn-hurley shawn-hurley merged commit dbd7d35 into konveyor:main Feb 8, 2024
6 checks passed
pranavgaikwad pushed a commit to pranavgaikwad/analyzer-lsp that referenced this pull request Feb 21, 2024
Fixes konveyor#482

---------

Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
pranavgaikwad added a commit that referenced this pull request Feb 21, 2024
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Co-authored-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Co-authored-by: David Zager <dzager@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Dependency string parsing fails when dependency is not JAR
2 participants