Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Adding jwt token authentication to the GRPC provider server #607

Merged
merged 1 commit into from
May 20, 2024
Merged

✨ Adding jwt token authentication to the GRPC provider server #607

merged 1 commit into from
May 20, 2024

Conversation

shawn-hurley
Copy link
Contributor

Adding authentication.

To test this:

  1. Create a JWT token with secret, after setting up TLS.
  2. set JWT token on the provider.
  3. set secret in the provider server (with env var OR the command line flag)

Run the provider

@shawn-hurley shawn-hurley force-pushed the feature/add-jwt-authentication branch from d7d154c to 66c686d Compare May 16, 2024 20:20
pranavgaikwad
pranavgaikwad requested changes May 16, 2024
View reviewed changes
Copy link
Contributor

@pranavgaikwad pranavgaikwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, need to remove go.mod updates at some places.

external-providers/generic-external-provider/Dockerfile Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to revert this back

external-providers/java-external-provider/go.mod Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

go.mod Show resolved Hide resolved
@shawn-hurley
✨ Adding jwt token authentication to the GRPC provider server
c10002a 
Signed-off-by: Shawn Hurley <shawn@hurley.page>
@shawn-hurley shawn-hurley force-pushed the feature/add-jwt-authentication branch from 66c686d to c10002a Compare May 17, 2024 14:11
@pranavgaikwad pranavgaikwad merged commit 8aa5f98 into konveyor:main May 20, 2024
6 checks passed
This was referenced Jun 22, 2024
Merged
Merged
This was referenced Jul 30, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavgaikwad pranavgaikwad pranavgaikwad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shawn-hurley @pranavgaikwad