Gradle support #93
Merged
Gradle support #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jmle
commented
Apr 26, 2024
•
jmle
commented
- Add JDK8 for wider Gradle support
- Set env variable with JDK8 location
- Add sources download script (not used yet)
- Remove old Maven dependency plugin installation (not needed anymore)
- Required for ✨ Gradle support analyzer-lsp#591 and part of the Gradle support enhancement
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
shawn-hurley
approved these changes
May 8, 2024
There was a problem hiding this comment.
VISACK
Got to be honest, if I have to ever touch this code, I am going to have look up a bunch of stuff. Is there any chance that we could add some comments that would at least point me in a direction or maybe a follow up with a small amount of docs on the build.gradle script?
shawn-hurley
reviewed
May 8, 2024
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.