🐛 Handle case when Running source only #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shawn-hurley
commented
Jul 1, 2024
shawn-hurley
commented
- Don't run dep analysis during source-only mode
- Don't add the dep label selector when source-only mode
Signed-off-by: Shawn Hurley <shawn@hurley.page>
* Skipping dep analsis * don't add a dep-selector when no dependencies Signed-off-by: Shawn Hurley <shawn@hurley.page>
|
It seems like we need to fix the CI tests. As it currently expects dependencies during source-only mode. |
Signed-off-by: Shawn Hurley <shawn@hurley.page>
shawn-hurley
force-pushed
the
bugfix/release-0.3-no-selectors-source-only
branch
from
257bb09
to
16cb3d6
Compare
|
Eating the error, is the best we can do for now in 7.0.3. in 7.1 we will handle this with success with errors |
|
sorry 0.3 and 0.5 respectfully upstream |
shawn-hurley
commented
Jul 5, 2024
| func (r *Scope) AddOptions(options *command.Options) (err error) { | ||
| if !r.WithKnownLibs { | ||
| func (r *Scope) AddOptions(options *command.Options, mode Mode) (err error) { | ||
| if !r.WithKnownLibs && mode.WithDeps { |
There was a problem hiding this comment.
Remove all other other work, in @jortel fix, this needs to be better documented and add comments
|
Closing we can re-open if we need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.